Fix NPCs traits removal by purification #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cataclysmbnteam#1670 Testing: 1. Started new game 2. Made friends with NPC 3. Made NPC drink purifier, notice no changes in traits. 4. Made NPC drink mutagen, notice new mutations. 5. Made NPC drink purifier, notice removal of mutations but preservation of original traits.
joveeater
pushed a commit
to joveeater/Cataclysm-BN
that referenced
this pull request
Jul 10, 2022
Fixes cataclysmbnteam#1670 Testing: 1. Started new game 2. Made friends with NPC 3. Made NPC drink purifier, notice no changes in traits. 4. Made NPC drink mutagen, notice new mutations. 5. Made NPC drink purifier, notice removal of mutations but preservation of original traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Stop purification from removal inherent traits of NPCs"
Purpose of change
Fixes #1670
Describe the solution
Replace
set_mutationbytoggle_traitat NPC generation.Describe alternatives you've considered
I don't have alternatives.
Testing
Testing:
Additional context
Would also file a new PR with removal of
toggle_traitsoon but it is harder to implement and test so this is fast bugfix.