Fix water cannons #1654
Merged
Fix water cannons #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joveeater
pushed a commit
to joveeater/Cataclysm-BN
that referenced
this pull request
Jul 10, 2022
* Move RECOVER_10 from water cannon to water * Validate gun(mod) ammo effects on startup * Fix couple errors found by the new check * Fix No Hope * Fix Aftershock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed debugmsg when firing water cannons"
Purpose of change
Fix #1638
Describe the solution
Move the flag from water cannon to water.
Validate gun (and gunmod) ammo effects on load.
Describe alternatives you've considered
Something more complex that allows gun(mods) to alter ammo recovery rates, but upon searching through BN repo and Kenan's modpack there seemed to be no cases of that actually being used in some meaningful way.
Testing
Loaded a random world, spawned fire engine, fired the water cannons.
Before fix: a debugmsg, no puddles.
After fix: a puddle, no debugmsgs.