Fix generation of adjacent elevated bridges #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll have to trust you here. Might be good if we had some way of forcing certain spawns, like an overmap seed instead of having overmapgen use same rng as everything else. |
|
Found a case "in the wild", the bridges look as they should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed generation of adjacent elevated bridges"
Purpose of change
As in the title. If 2 (or more) bridges generated next to each other, the code that elevates them would wrongly detect bridgeheads and make an untraversable mess.
Describe the solution
Refine the check, and also clean oter_id rotation API a bit.
Describe alternatives you've considered
Watching people suffer
Testing
I wasn't lucky enough to get an overmap with 2 adjacent bridges show up, so I had to hardcode them in (not present in PR), and the new elevation code seemed to be discerning them properly. Also teleported to bridgeheads, they also seem fine.