Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sane aft frame folded volume #1622

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

Secret-Cisco
Copy link
Contributor

Summary

SUMMARY: Balance "Made the Aftershock foldable ultralight frame a more sane folded volume"

Purpose of change

The afs foldable frame folded to 10 L which is far larger than any base foldable frame and is also significantly larger than the item it is installed from. In addition, the name of the part is inconsistent with the other foldable frames.

Describe the solution

Frame folded volume is now 4 L down from 10. Part name string is now "foldable ultralight frame" to match all the other foldable [material] frames.

Describe alternatives you've considered

A different volume than 4 L.

Testing

  • Created a new save with a folded ultralight vehicle
  • saved & quit
  • modified the JSON
  • folded ultralight vehicle is same volume as before
  • unfolded & refolded vehicle
  • it's now the lower volume

So it loads just fine and doesn't seem to break anything, just needs to be recalculated.

Additional context

@Coolthulhu Coolthulhu self-assigned this Jun 19, 2022
@Coolthulhu Coolthulhu merged commit 181088e into cataclysmbnteam:upload Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants