Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routine i18n updates on 04 June 2022 #1578

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Routine i18n updates on 04 June 2022 #1578

merged 1 commit into from
Jun 7, 2022

Conversation

Coolthulhu
Copy link
Member

Summary

None

@Coolthulhu Coolthulhu changed the title Routine i18n updates on 28 May 2022 Routine i18n updates on 04 June 2022 Jun 4, 2022
@Coolthulhu Coolthulhu self-assigned this Jun 5, 2022
@scarf005
Copy link
Member

scarf005 commented Jun 5, 2022

original  :It should take %d minutes to finish washing items in the %s.
translated:%s의 내용물을 세탁하는데 %d분 걸립니다. 
(literally translates to: to wash items in the %s, it takes %d minutes)

https://github.com/cataclysmbnteam/Cataclysm-BN/runs/6735532836?check_suite_focus=true

could changing order of formatting literals cause problems?
if then, are there any guides regarding this problem?

@Coolthulhu
Copy link
Member Author

could changing order of formatting literals cause problems?

They might not be substituted correctly, I think.
The easiest fix would be to add positionals to every translatable string with 2+ format specifiers.

@Coolthulhu Coolthulhu merged commit 5e0ab21 into upload Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants