Port over regen modifiers #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added moddable regeneration-modifers system for monsters Co-authored-by: mrpal <parchiele@gmail.com> Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com> Co-authored-by: Kevin Granade <kevin.granade@gmail.com>
a14fc1a to
e4069db
Compare
Effect Intensity affects reduction
For whatever reason it was comparing to maxhp instead of current HP.
This won't "stack" on body parts as it does on players, might look into that another time.
359b685 to
ca67666
Compare
|
It's a bit hard to test with current UI because it doesn't show the heal amounts, but onfire+corroding sludge crawlers are clearly less able to regenerate than healthy ones, so it works. |
Yeah, for the duration of my testing I had it print the results from the heal function, it's how I learned that it doesn't function as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Allow regeneration to be modified by effects."
Purpose of change
Regenerating monsters currently don't push for smart approaches, preferring a more dakka approach that doesn't really encourage any kind of tactics.
Describe the solution
Port over #50439 from DDA which extends regeneration and allows effects like on fire, corroding and the like to modify the amount healed.
Change it to multiply regeneration by specific amount instead, instead of a flat addition/reduction, which should be more comfortable to use.
Describe alternatives you've considered
Disable regen entirely under specific effects.
Testing
Spawned Debug Monster, used molotovs/acid bombs to set them on fire/give them acid burns. Tested that amount of reduction was appropriate, and that multipliers were being used correctly.
Additional context
Fixed several issues while I was at it. For one, heal function wasn't returning the amount healed but rather the difference between current hp and max hp. Furthermore, monsters did not suffer from the Corroding condition, meaning I couldn't trigger the effects of regeneration modifiers on them.
Finally, this should allow us to bump up regen on more monsters, like the experimental mutant that only regens 1 HP per turn, or even dissoluted devourers. That said, before we start doing this we need more and better ways to apply burning/corroding to monsters. Incendiary rounds seem somewhat unsatisfactory and acid bombs also make it near impossible to enter the area if you're melee or want to loot the corpse.