add auto-start at 99% option for power generating bionics #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messages are disabled because it'd be too much spam
used bool lambda for if checks. merged msg functions to one, i18n works (checked in korean)
Coolthulhu
reviewed
May 24, 2022
"keep fully charged" can be misleading as 100%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "add auto-start at 99% option for power generating bionics"
Purpose of change
currently auto-start mode for power generating bionics are 0%, 25%, 50%, 75%.
however there are times when maximum power is low and keeping it full is important.
Describe the solution
adds 99% option. auto-activation and deactivation message is disabled in order to prevent message spam.
Describe alternatives you've considered
there might be a better way to handle situations like this, but at least this is simple enough to implement.
Testing
I'll have to fix with catch.hpp
Additional context