Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauling Specific Use Storage, part 4 #1517

Merged
merged 6 commits into from
May 13, 2022

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented May 7, 2022

Summary

SUMMARY: Balance "Update Specific Use Storage, dressers and wardrobes"

Purpose of change

Part four of overhauling the Specific Use Storage itemgroups. Per discussion on the BN discord, I was reminded that the dresser spawns of the SUS itemgroups were also on the list to be fixed up. As usual it leaned towards massive spawns of relatively identical items, often disproportionately spawning some of the exact same few items, most famously hilarious amounts of kilts.

Part of it is because itemgroups for men-only and women-only items (kilts vs skirts for example) were called about as often as unisex clothing spawns, and since the former has way lower variety of items that meant they'd show up a lot more than expected.

Describe the solution

  1. Reworked the dresser itemgroups. Mainly, merge calls for unisex vs. gendered clothing into a single either-or instead of trying to roll to spawn both, and skew the relative weights of unisex vs. gendered items based on how little stuff is in the latter. For example, it'll pick pants_unisex over pants_mens 95% of the time because pants_mens only has kilts in it, gloves_womens shows up less often because its only contents are the opera gloves, etc.
  2. Also reworked the wardrobe itemgroups. In addition to merging unisex vs. gendered clothing spawns as above, it also does away with the mix of extra random stuff in favor of a new itemgroup for that, wardrode_sporting_misc. This is used to spawn the sleeping bags, chaps, football armor etc. Its variety has also been expanded a bit, divided up into hunting gear (quivers and bandoliers), outdoors sporting goods clothing (i.e. camping, fishing, etc), and general sports equipment, focusing on stuff not injected into other dresser/wardrobe clothing itemgroups.
  3. Also reworked how accessories spawn to spawn extras less often, but with a better variety of them.

Describe alternatives you've considered

Could look at other dresser itemgroups to see if anything notable is missing.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested to grab an example item group test.

Additional context

Example, mens' dresser itemgroup, before:
dresser_men, before

Example, mens' dresser itemgroup, after:
image

@Coolthulhu Coolthulhu self-assigned this May 10, 2022
@Coolthulhu
Copy link
Member

wardrode_sporting_misc

Why wardroDe?

@chaosvolt
Copy link
Member Author

Why wardroDe?

Typo, whoops. XD

@Coolthulhu Coolthulhu merged commit 4680797 into cataclysmbnteam:upload May 13, 2022
@chaosvolt chaosvolt deleted the sus-rework-dressers branch May 13, 2022 17:38
scarf005 pushed a commit to scarf005/Cataclysm-BN that referenced this pull request May 13, 2022
* Overhauling Specific Use Storage, part 4

* Tweak accessory spawn

* Whoops, forgot to lint after last update

* Forgot to convert to distribution

* Update domestic.json

* Typofix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants