Consistency updates for bandoliers

[chaosvolt]

Summary

SUMMARY: Balance "Rebalance bandolier capacity for consistency relative to shotgun bandoliers, based off average volume of ammo used"

Purpose of change

Bandoliers are in a bit of a weird niche, their intended main advantage is a reduction in reload time, but with it being 0.8 seconds faster on average that tends to be moot compared to being able to carry extra ammo. I personally feel that these two advantages aren't that great on their own, but are perfectly fine when combined, enough to make for a solid balance against their primary drawback of giving up a fairly valuable torso slot.

For shotgun bandoliers the numbers check out just about right I feel, but the problem is pistol and rifle bandoliers, which hold less of ammo that tends to be smaller than what the player will likely be filling shotgun bandoliers. Moreover, most of these ammo types, especially in the case of pistol ammo, will usually be less damaging than shotshells, so a bandolier's worth of shotshells will already last you longer in a fight than the other bandolier types.

While adjusting reload and draw speed mechanics would be a good long-term solution to making bandoliers more useful for their "main" job of drawing ammo faster, and I don't feel that simply removing them is the best solution either, I feel that it'd fit its current niche (two minor benefits that combined become worth occupying waist or wrist slots) better if the bandoliers for ammo that tends to be smaller and lighter held enough to be worth it relative to the shotgun bandolier at minimum. This is also something that can be hashed out easily without code changes, and would likely be something I'd do anyway alongside a draw cost code change because it's still a major inconsistency.

Describe the solution

There are many ways to potentially determine how much more valuable storage space for each ammo type was, but for this I decided to go with consistency based on the averaged volume of all ammo types usable in a given bandolier, and that would be:

Type	Average volume per round
Pistol	8 mL
Rifle	14 mL
Shot	14 mL

Flintlock was an exception however, its average is 30 mL per shot because blunderbuss rounds are 100 mL per shot, twice that of .700 NX (rifle bandolier's biggest ammo) and four times that of .500 Magnum (pistol bandolier's biggest ammo option). The much lower range of ammotypes also makes its impact that much more disproportionate compared to how the biggest ammo. Ignoring this outlying value instead gives an average of 17.5 mL.

1. Increased capacity of pistol bandolier from 18 to 40 rounds, a few under the 43.5 the above ratio would yield.
2. Increased capacity of rifle bandolier from 16 to 25 rounds, equal to that of shotgun bandolier.
3. Increased capacity of wrist bandolier from 4 to 6 rounds, keeping it ~25% of the rifle bandolier as before.
4. Increased capacity of flintlock pouch from 14 to 20 rounds, in line with the 17.5 mL figure above.
5. Updated professions, moving some of the loose ammo in the reenactor professions to their pouch. Rifle hunter was left untouched because a stack of .270 Winchester is still only 20 rounds, which is why they had no loose ammo to spare (in fact, I'm 90% sure the 16 round capacity was arbitrarily chosen just to allow rifle hunters to hold exactly 1 stack in their gun and bandolier).
6. Gunslinger profession given an actual stack's worth of .45 Colt (40 rounds), 6 in their gun and 34 in their bandolier, for consistency with the above.

Describe alternatives you've considered

Grenade and stone pouches in comparision are a lot harder to balance and were left untouched for now. The former because the values again have a massive disparity but they come out to an average that would justify bumping its ammo capacity up by 1 which is barely a tweak, plus it varies IMMENSELY (arguably far more than any other bandolier type) just how useful those rounds are relative to what other bandoliers can carry. The latter meanwhile because rocks are massive but also easy to scavenge, but also furthermore their damage is pistol-tier. The fact they're belted slot is honestly more tempting to change than their capacity, giving up a backpack for 10 rocks is a bit wacky.

The generic ammo pouch is in a weird position. As a "crappy item that holds a fuckton of ammo" niche it's good, but whereas encumbrance isn't enough of an issue to need any substantial tweaks for bandoliers, 5-11 encumbrance is a lot. 60 of even the biggest ammo you could expect to hold in it won't even really make a dent in your encumbrance in a generic backpack, but it does make up for it by being able to hold some wacky ammo options nothing else can. But on the other hand, it also lacks the ability to hold some things other bandolier-type items can, like blunderbuss rounds.

Other schemes for consistency include:

1. Basing it off a reasonable example of the most common ammo you're likely to carry. That would make pistol bandoliers hold 70 rounds (9x19mm, 5 mL), rifle bandoliers 55-60 rounds (5.56x45mm, 6 mL), and no change for flintlock pouches (paper cartridge, 25 mL).
2. Shaving off the single biggest ammo type for pistol and rifle cartridges, as done with flintlock pouches. This changes far less than what not counting blunderbuss rounds does, to be honest.
3. Instead maintaining the same ratios of ammo capacity except inverted the other way around and shuffled as needed, i.e. multiplying 25 by 25/14, 25,16, 25/18 would give us amounts of roughly 45, 40, and 35 to assign as desired.
4. Saying "fuck it" and just making them all multiples of 15.

Other possible ideas:

1. Making raw cost tend towards zero to make its other main advantage more useful too. 20 centiseconds is infinitely more trivial than "I can't carry anywhere near as many rifle rounds as shotshells" though.
2. Just making (or making a mod for) bandoliers not even counting as being worn on any slot at all, so the player can wear up to 3 of every type without caring about the encumbrance penalties at all.
3. Importing over the hat bandolier idea from Cataclysm++, with or without survivor cowboy hats coming along for the ride.

Testing

Checked affected files for syntax and load errors.

Additional context