Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDA port #53764: Add cursor navigation to the mutations UI #1484

Merged
merged 7 commits into from
May 3, 2022

Conversation

SaintCirno9
Copy link
Contributor

Summary

SUMMARY: [Interface] "Add cursor navigation to the mutations UI"

Purpose of change

To fix #1479

Describe the solution

Cherry-picked from CleverRaven/Cataclysm-DDA#53764

Describe alternatives you've considered

Testing

Seems working fine.
GIF 2022-4-24 18-22-46

Additional context

CleverRaven/Cataclysm-DDA#54204 is also included.

Rovallen and others added 6 commits April 24, 2022 17:33
…made.

(cherry picked from commit 319363950e00dcf94055d4a2ee1b4117392e645f)
(cherry picked from commit 543e420316a872bdf19edf682ff25bad356972b6)
(cherry picked from commit 3b9a453197beea83c83144bded89055c0e154c08)
(cherry picked from commit 604800602cef5b5c969036ef9662d221c4a63e09)
(cherry picked from commit 97bee1ba9502b76e19009edf64f22e81899b80b4)
Co-authored-by: Rovallen <agibalov.23@mail.ru>
@SaintCirno9
Copy link
Contributor Author

So Clang 9 test failed, but I can't really figure out why and cannot test it without corresponding environment.

@chaosvolt
Copy link
Member

rng_test.cpp:19: FAILED:
  CHECK( stats.test_threshold( target_range ) )
with expansion:
  false
with messages:
  Goal: -1.1
  Result: -1.01
  Samples: 100

Looks unrelated to me.

@Coolthulhu Coolthulhu self-assigned this Apr 25, 2022
@SaintCirno9
Copy link
Contributor Author

Weird.
Is this Clang 9 test fail just happen randomly?
Pushed an empty commit then all tests passed.

@Coolthulhu
Copy link
Member

Coolthulhu commented Apr 27, 2022

Was a RNG error. I should probably just disable those tests, 99% of the time they break due to RNG alone.

EDIT: I mean those tests that fail all the time, not all tests, of course.

@Coolthulhu Coolthulhu merged commit e152ef9 into cataclysmbnteam:upload May 3, 2022
@SaintCirno9 SaintCirno9 deleted the mutation-ui-port branch May 28, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not enough characters to represent all mutations
4 participants