Don't silently fail when attempting to modify vits #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, attempting to modify a vitamin would silently fail when the character's `vitamin_levels` map did not contain that vitamin. However, this map never actually had vitamins added to it... except when the game was loaded, in deserializing the character's vitamin levels. This doesn't appear to be very purposeful, just a side effect of using the ids of the vitamins as keys for the amount of that vitamin, and not bailing out if the key was not found. This meant on the first time a new character was loaded, before you saved and reloaded, any vitamins would not work, particularly the blood vitamins. Stop silently failing when attempting to modify a vitamin that is not already contained, and instead add it to the `vitamin_levels` map, and change the character loading function to avoid the behavior that hid this problem in the past - filling out the vitamin map completely even if there was nothing to load for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Fixes vitamin bug that prevents new chars from gaining/losing vitamins.
Purpose of change
Fixes #1466 so that newly created characters will have vitamins change, particularly useful in our case for mutagenic toxins.
Does this by porting 42044 from DDA.
Describe the solution
Describe alternatives you've considered
Testing
Created new custom character, add mutant lard and waited 30 minutes. Checked that mutagenic toxins rose. Saved and loaded char and ensured progression of mutagenic toxins continued.
Additional context