Rename USE_HOME_DIR save/conf dir to cataclysm-bn #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Build "Rename USE_HOME_DIR save/conf directory to cataclysm-bn"
Purpose of change
When building Cataclysm-DDA and Cataclysm-BN both with USE_HOME_DIR, they both use the same directory for saves/config, which are not compatible. This causes game-configuration related errors and could result in accidentally loading the wrong save.
Describe the solution
Directory name changed cataclysm-dda to cataclysm-bn.
Describe alternatives you've considered
The main problem with this is saves/config would have to be moved manually - for example on Linux the contents from ~/.cataclysm-dda/ to ~/.cataclysm-bn/. This could cause confusion and people may think their saves were deleted after updating. Another option would be to have a make flag to do this / change the path on compile, and leave it to the user to handle it. I did not do this because I think it would be preferable for the default not to conflict with Cataclysm-DDA.
Testing
Tested with USE_HOME_DIR on Linux and MacOS.