Optimize electric grid #1461
Merged
Optimize electric grid #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: [Performance] "Optimize electric grid"
Purpose of change
To fix #1322
Describe the solution
The profiler result in #1322 is rather inaccurate because of the compile options we use, I guess.
In fact, the major performance eater in
electric_grid_atis the copy of thetripoint_abs_omt, which is weird.Simply using a reference there solves the lag.
Describe alternatives you've considered
Testing
Load the save attached in #1322 , then walk around.
Before this PR
After this PR
Additional context
I also made the
distribution_grid_tracker::on_saved()only reload needed things, but the improvement is not as significant as the reference used inelectric_grid_at.