Blood Filter CBM update to remove Badly Poisoned status #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blood Filter now removes Badly Poisoned status.
Purpose of change
Didn't seem like there was a good reason to have Badly Poisoned not be affected at all by Blood Filter CBM. It is still a toxin in your bloodstream after all.
Describe alternatives you've considered
One of my considerations was that Badly Poisoned could be downgraded to just Poisoned before being removed on the 2nd "flush", this would throw in resource and turn management considerations into avoiding Badly Poisoned to begin with. However I lack the technical knowhow to make this work, so this is what you get.
Testing
Walked into Poison Gas, activated Blood Filter CBM, saw poison removed.
Additional context
Blood Analysis CBM considers both Badly Poisoned and Poisoned to be separate conditions but simultaneously calls them poisoned. I'd hope that this could be changed later on.