Remove libintl dependency and LOCALIZE build switch; fix MSVC release localization; properly like with wide curses in CMake build #1433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Removed libintl dependency and LOCALIZE build switch"
Purpose of change
Build simplification, bugfixing
Describe the solution
libintl
dependency that is essentially obsolete now that BN has its own translation systemLOCALIZE
build switch since it's purpose is to conditionally turn offlibintl
callsMODULAR_TRANSLATIONS
option that's used for switching between BN translation system andlibintl
msvc
release builds(based on code from CleverRaven/Cataclysm-DDA@e46e116 )
(cherry-picked from Link to libncursesw in CMake CleverRaven/Cataclysm-DDA#55054)
Testing
Ensured that all workflows complete successfully on my own fork.
Tested that the following builds don't crash on launch and properly display Unicode characters: