Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libintl dependency and LOCALIZE build switch; fix MSVC release localization; properly like with wide curses in CMake build #1433

Merged
merged 11 commits into from
Apr 6, 2022

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented Apr 3, 2022

Summary

SUMMARY: Build "Removed libintl dependency and LOCALIZE build switch"

Purpose of change

Build simplification, bugfixing

Describe the solution

  1. Remove libintl dependency that is essentially obsolete now that BN has its own translation system
  2. Remove LOCALIZE build switch since it's purpose is to conditionally turn off libintl calls
  3. Remove MODULAR_TRANSLATIONS option that's used for switching between BN translation system and libintl
  4. Fix translations in msvc release builds
    (based on code from CleverRaven/Cataclysm-DDA@e46e116 )
  5. Link to wide ncurses library in CMake build
    (cherry-picked from Link to libncursesw in CMake CleverRaven/Cataclysm-DDA#55054)

Testing

Ensured that all workflows complete successfully on my own fork.

Tested that the following builds don't crash on launch and properly display Unicode characters:

  • android release build
  • linux curses release build
  • linux tiles release build
  • linux cmake curses build
  • windows mxe release build
  • windows msvc release build

@olanti-p olanti-p changed the title Remove libintl dependency and LOCALIZE build switch; fix MSVC release localization; properly detect wide curses in CMake build. Remove libintl dependency and LOCALIZE build switch; fix MSVC release localization; properly like with wide curses in CMake build Apr 3, 2022
@Coolthulhu Coolthulhu self-assigned this Apr 4, 2022
@Coolthulhu Coolthulhu merged commit d66bf93 into cataclysmbnteam:upload Apr 6, 2022
@olanti-p olanti-p deleted the remove-libintl branch July 17, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants