Dismantle unused legacy migrations feature #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1413 small steps towards elegance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Removed unused legacy migrations feature"
Purpose of change
Mirrors CleverRaven/Cataclysm-DDA#48871
Legacy migrations feature is essentially dead code at this point; these days all obsolete entries are moved to
data/json/obsoletion/first, and are removed much later.Describe the solution
Rip relevant code out, delete ancient migration entries.
Describe alternatives you've considered
Let the bit rot prevail.
Testing
Compiled, loaded an existing save, observed to crashes.