Fix a crash when using chop tree zones (#3016)

cataclysmbnteam · Jul 14, 2023 · 522002b · 522002b
1 parent f9effce
commit 522002b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/activity_handlers.cpp b/src/activity_handlers.cpp
@@ -4232,10 +4232,17 @@ void activity_handlers::chop_tree_finish( player_activity *act, player *p )
     act->set_to_null();
 
     // Quality of tool used and assistants can together both reduce intensity of work.
+    if( act->targets.empty() ) {
+        debugmsg( "woodcutting item location not set" );
+        resume_for_multi_activities( *p );
+        return;
+    }
+
     item_location &loc = act->targets[ 0 ];
     item *it = loc.get_item();
     if( it == nullptr ) {
         debugmsg( "woodcutting item location lost" );
+        resume_for_multi_activities( *p );
         return;
     }
 

diff --git a/src/activity_item_handling.cpp b/src/activity_item_handling.cpp
@@ -2453,10 +2453,12 @@ static bool chop_tree_activity( player &p, const tripoint &src_loc )
     const ter_id ter = here.ter( src_loc );
     if( here.has_flag( flag_TREE, src_loc ) ) {
         p.assign_activity( ACT_CHOP_TREE, moves, -1, p.get_item_position( best_qual ) );
+        p.activity.targets.push_back( item_location( p, best_qual ) );
         p.activity.placement = here.getabs( src_loc );
         return true;
     } else if( ter == t_trunk || ter == t_stump ) {
         p.assign_activity( ACT_CHOP_LOGS, moves, -1, p.get_item_position( best_qual ) );
+        p.activity.targets.push_back( item_location( p, best_qual ) );
         p.activity.placement = here.getabs( src_loc );
         return true;
     }