Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Request textDocument/hover failed #82

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

piktur
Copy link
Contributor

@piktur piktur commented Aug 19, 2018

Great news from #81! Looking forward to the improvement. In the meantime this PR attempts to ensure correct type for String addition:

VSCode log output

[Error] Request textDocument/definition failed.
  Message: [TypeError] no implicit conversion of nil into String
  Code: -32603 

and backtrace from VSCode DevTools
screen shot 2018-08-19 at 22 55 36

Cheers

@castwide
Copy link
Owner

Thanks for tracking this one down. It'll be included in version 0.25.1.

@castwide castwide merged commit d00ed90 into castwide:master Aug 19, 2018
@castwide
Copy link
Owner

Writing a spec for this case, I noticed that similar problems can happen with a few other Fragment methods, so I added some more changes to ensure that word, remainder, signature, base, and chain (and methods that compose from them like whole_word) always return strings. Thanks again for the catch.

@piktur
Copy link
Contributor Author

piktur commented Aug 20, 2018

Brilliant, thanks again for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants