Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nest gemspec dependency when yardoc error #599

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix nest gemspec dependency when yardoc error #599

merged 1 commit into from
Dec 8, 2022

Conversation

SolaWing
Copy link
Contributor

this patch fix following problem, make nest gem dependency more robustness and usable

  1. gemspec dependency should prefer bundle version, not the global gem version
  2. capture nest no yardoc error, avoid lost all pins in require-chain, even some have yardoc

refactor:

unify yardoc pins load for root and dependencies

@SolaWing
fix nest gemspec dependency
f7142c9 
this patch fix following problem, make nest gem dependency more robustness

1. gemspec dependency should prefer bundle version, not the global gem version
2. capture nest no yardoc error, avoid lost all gem dependency yardoc

refactor:

unify yardoc pins load for root and dependencies
@castwide
Copy link
Owner

castwide commented Dec 8, 2022

Thanks!

@castwide castwide merged commit caf6bcb into castwide:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SolaWing @castwide