Ci against ruby27 #253
Merged
Ci against ruby27 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RSpec fails with Ruby 2.7. https://travis-ci.org/castwide/solargraph/jobs/629586594#L915-L927 Failures:
916
917 1) Solargraph::TypeChecker ignores undefined return types from external libraries
918 Failure/Error: expect(checker.strict_type_problems).to be_empty
919 expected `[#<Solargraph::TypeChecker::Problem:0x0000000003b2ce30 @location=#<Solargraph::Location test.rb, #<So...tion 5, 27>>>, @message="Unresolved method signature Benchmark.measure", @pin=nil, @suggestion=nil>].empty?` to return true, got false
920 # ./spec/type_checker_spec.rb:187:in `block (2 levels) in <top (required)>'
921
922Finished in 24.61 seconds (files took 1.92 seconds to load)
923676 examples, 1 failure
924
925Failed examples:
926
927rspec ./spec/type_checker_spec.rb:175 # Solargraph::TypeChecker ignores undefined return types from external libraries |
|
lsegal/yard#1296 should be a better fix. |
* Ruby 2.7.0 Released https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/
``` /home/travis/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require': cannot load such file -- e2mmap (LoadError) ``` https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/ ``` The following libraries are no longer bundled gems. Install corresponding gems to use these features. * CMath (cmath gem) * Scanf (scanf gem) * Shell (shell gem) * Synchronizer (sync gem) * ThreadsWait (thwait gem) * E2MM (e2mmap gem) ```
``` /home/travis/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require': cannot load such file -- irb/slex (LoadError) ``` Refer ruby/ruby@efbca15 lsegal/yard#1290 (comment)
|
Thanks a lot for working on this. Do you expect to push any more commits? It looks to me like the only failing spec is an errant TypeChecker warning due to the |
Closed
|
Thanks for the update. As long as you are going to fix the TypeChecker failure with benchmark gem, I have no plan to push any more commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request runs CI against Ruby 2.7. There are some issues with this pull request. Let me work on later.