Allow overriding core doc cache directory #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XDG Base Directory Specification aims to define single directories where all files of a similar nature are stored, rather than storing everything hidden in the home folder.
Following the specification, the location for the core docs should be at
$XDG_CACHE_HOME/solargraph, defaulting to$HOME/.cache/solargraph. If not hard-coding the XDG directory by default (keeping in mind non-Linux users), it would be good to be able to override the cache directory location if the user desires.Of course take this with a grain of salt as I'm a primary Linux user and don't know the experience for MacOS or Windows.