Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MS MARCO passage dev with Cohere V3 embeddings #2366

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

lintool
Copy link
Member

@lintool lintool commented Feb 10, 2024

Added int8 indexes, general clean-up, added links to README.

@cadurosar we're missing dl19/dl20 - what do you want to do? Send in separate PR?

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f86a65f) 65.66% compared to head (7f68cf5) 65.66%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2366   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity     1398     1398           
=========================================
  Files           207      207           
  Lines         11631    11631           
  Branches       1471     1471           
=========================================
  Hits           7637     7637           
  Misses         3484     3484           
  Partials        510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool
Copy link
Member Author

lintool commented Feb 10, 2024

@cadurosar says we should go ahead and merge this, and circle back to add dl19/dl20 later.

@jasper-xian will wait for your CR first.

@lintool lintool merged commit 57d2627 into master Feb 11, 2024
3 checks passed
@lintool lintool deleted the cohere-refactoring branch February 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants