Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beir-flat-wp (word piece) tests #1880

Merged
merged 22 commits into from
May 21, 2022

Conversation

amyxie361
Copy link
Member

add arguana yaml and template

@amyxie361 amyxie361 requested review from justram and lintool May 19, 2022 22:12
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #1880 (4200711) into master (2c70ebc) will not change coverage.
The diff coverage is n/a.

❗ Current head 4200711 differs from pull request most recent head 0f571a5. Consider uploading reports for the commit 0f571a5 to get more accurate results

@@            Coverage Diff            @@
##             master    #1880   +/-   ##
=========================================
  Coverage     57.74%   57.74%           
  Complexity     1058     1058           
=========================================
  Files           179      179           
  Lines         10301    10301           
  Branches       1417     1417           
=========================================
  Hits           5948     5948           
  Misses         3852     3852           
  Partials        501      501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c70ebc...0f571a5. Read the comment docs.

Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…plate

Co-authored-by: Jimmy Lin <jimmylin@uwaterloo.ca>
@lintool
Copy link
Member

lintool commented May 19, 2022

Also remember to update README.md.

@amyxie361
Copy link
Member Author

@lintool
Hi Jimmy, I uploaded the yaml and template for all the datasets, all python script passes the test. Could you double check and I will merge these changes.
One question: do I have to commit the auto-generated .md files?
For README.md, I will add in a separate PR.

Best,
Yuqing

@lintool
Copy link
Member

lintool commented May 21, 2022

Yes, please check in the auto-generated .md files also.

@amyxie361 amyxie361 merged commit d457c88 into castorini:master May 21, 2022
@amyxie361 amyxie361 deleted the yuqingxie/add-beir-word-piece branch May 21, 2022 19:05
@amyxie361 amyxie361 changed the title Yuqingxie/add beir word piece Add beir-flat-wp (word piece) tests May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants