-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop testing for .NET Core 2.1/3.1 and update some nuget packages #660
Conversation
I tend to agree that testing on these now-unsupported platforms, by itself, isn't that important anymore... however, since this library targets IIRC, it is for the .NET Standard TFMs that we're currently testing on .NET Core 2.1 and 3.1. Given that .NET 5 has started moving away from .NET Standard starting with version 5 (see the official docs), one might wonder why we are even keeping these TFMs around at all. .NET 4.6.2 and 6 (the two other TFMs) already cover .NET Standard 2.x, and we're not testing our library for any other platforms that support it (Xamarin, UWP, Unity, etc.); Mono being the sole exception, but that falls under the The main reason to keep targeting I suppose dropping Maybe I'm overthinking this... any opinions? @jonorossi? |
Yea, we are king of in the middle of evolution .NET ecosystem. At the same I think that make sense start thinking about dropping .NET Standard 2.1 |
@stakx I think you've got it right. Microsoft has the following recommendations for when to keep using .NET Standard, and that's for libraries that want to share between .NET Framework and .NET [Core], which is still useful for libraries that depend on interfaces defined in
I agree we should only run unit tests on supported .NET platforms, and the build warnings need to be cleaned up, e.g.:
|
@jonorossi, cleaning up the build warnings would be easy enough by simply suppressing them (I'll look into it!), but are you suggesting we go further and drop the |
@stakx I think best to come back to this after your list of areas to address post the next release. Some parts of the library that'll get pulled out could just target .NET Standard only. |
Motivation:
Soon .NET 8 will be released and this PR is part of preparation for this. Small cleanup of build\test system
Changes:
This pr do not change product by itself. Only test\build infrastructure. No need to release new nuget package version
.Notes:
.NET Core 2.1 is out of support
https://devblogs.microsoft.com/dotnet/net-core-2-1-will-reach-end-of-support-on-august-21-2021/
.NET Core 3.1 is out of support
https://devblogs.microsoft.com/dotnet/net-core-3-1-will-reach-end-of-support-on-december-13-2022/