NLogFactory - Removed explicit loading of nlog.config by default

[snakefoot]

Since NLog will automatically load its configuration. Resolves #418

See also: https://github.com/nlog/NLog/wiki/Configuration-file#configuration-file-locations

[stakx]

Since this changes the default behavior of NLogFactory, I think this change should be mentioned in the changelog.

[snakefoot]

@stakx Have now updated the ChangeLog.md

[stakx]

I am not overly familiar with NLog and Castle's logging facilities, but your change looks good to me in principle. Here's a couple of thoughts I had while looking over your PR.

[devop228]

I look at the constructor overload NLogFactory(bool configuredExternally), its existence seems redundant since it leads to almost same behavior on both path of the code. Would removing it completely be too much a breaking change?

[snakefoot]

@devop228 You are welcome to create your own PR

[jonorossi]

I look at the constructor overload NLogFactory(bool configuredExternally), its existence seems redundant since it leads to almost same behavior on both path of the code. Would removing it completely be too much a breaking change?

@devop228 that is what I proposed in #418 before this pull request was created.

Since Windsor's logging facility only has an ConfiguredExternally method, you cannot get Windsor to pass false unless you use the custom factory overload.

I'm going to close this pull request because I think just doing this makes thing inconsistent between log4net and NLog, and doesn't push us to where we want to be with the factory's being just a shim, and not setting up configuration.