-
-
Notifications
You must be signed in to change notification settings - Fork 215
Export squish library (advanced CMake option) #244
base: master
Are you sure you want to change the base?
Conversation
… for future optional inclusion.
…ith an adequate warning to tell this is not the 'official' way).
… the same for BC6H and BC7 libs).
Additional notes:
|
Hi, I was in the process of entirely removing squish from NVTT. NVTT now has its own clusterfit implementation that has slightly higher quality, and I think squish is not really needed anymore. Wouldn't this be a better solution for the conflicts? |
Well, as long as I can decode/encode "good old" DXT1-3-5 images, and read/write them to disk, I'm in! |
Hmm, will you include these tiny changes in order to wait for the squish replacement? When will this replacement be available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -17,6 +17,7 @@ | |||
#include "nvcore/StrLib.h" | |||
#include "nvcore/StdStream.h" | |||
#include "nvcore/TextWriter.h" | |||
#include <cstdint> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required? Where are sized int types referenced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this one was made a long time ago, and I don't remember...
I'd be happy to include the changes. I need to do a bit more testing before I can drop squish completely, but I just wanted to let you know that was the plan, and that some of these changes would be removed at that point. What's not clear to me is why do you want to install the internal copy of squish. If you need to use squish directly, why don't you the original squish instead of nvtt's? |
Oh well, nothing really vital... I just wanted to avoid one more library with its own build system (I have many). It was easier for me to install the internal NVTT's squish than having to configure, build, install and integrate the external one. |
I have the need for both NVTT and squish for my project. This sounds particularly weird, as NVTT contains a (modified) copy of squish.
I thus made changes to directly use this squish copy. As this is not really the normal dev path, I added this as "advanced options" in CMake. Changes are:
This is quite straightforward. I hope this would help.