Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to check if the form is valid programatically and fixing that unchecked listeners were marking the form as with errors when there was no error #37

Merged
merged 1 commit into from
Jun 3, 2013

Conversation

edulix
Copy link

@edulix edulix commented May 29, 2013

This time, coffee script based. both things are in the patch.

…nchecked listeners were marking the form as with errors when there was no error
@casperin
Copy link
Owner

edulix good stuff. Github tells mere are conflicts though, so I can't just merge it in right away. Hopefully I'll get some time during the weekend though :)

@cheluis
Copy link

cheluis commented May 31, 2013

Hi! Firstly, nice work, I preffered nod over jqbootstrapvalidation because nod doesn't mess the html. But I have a question. If I have a drop down with a (select) option with a null value, it displays the error, on the initial state of the page. Is there a way to avoid this behaviour? Or, how can I fire the validations after the submit button is clicked?

@casperin
Copy link
Owner

casperin commented Jun 1, 2013

Hi, thanks. Annoyance with having to meddle with the html was exactly why I created it :-)

I'm not quite sure I understand your problem. That sounds like unexpected behavior to me (just like a text field shouldn't show an error upon loading, just because it can't be empty). If you mock something up with js fiddle or something, then I'll be happy to take a look.

@casperin casperin merged commit 4707988 into casperin:master Jun 3, 2013
@casperin
Copy link
Owner

casperin commented Jun 3, 2013

👍
Not sure I like the @Form[0].__nod way of doing things, but I can't think of something better, and I actually need this patch myself right now :-)

@edulix
Copy link
Author

edulix commented Jun 3, 2013

Thanks! It always feels right to contribute with upstream in an open source software project.

@cheluis
Copy link

cheluis commented Jun 3, 2013

How can I load nod's files into a fiddle? sorry for the noob question =$

@casperin
Copy link
Owner

casperin commented Jun 3, 2013

@edulix I added you on the contributor list too :) Thanks man.

@cheluis ouch, they changed how to add scripts :( Here's an idiot way of doing it: http://jsfiddle.net/AyYBT/ -- I basically just copied the entire library into the javascript field and added the "real" code at the very bottom.

@cheluis
Copy link

cheluis commented Jun 3, 2013

@casperin Thanks. I'll post an entry in the issues with the description of my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants