Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_mMR_from_file ignore parameters? #3

Closed
KrisThielemans opened this issue Jul 27, 2020 · 1 comment · Fixed by #5, #8 or #9
Closed

get_mMR_from_file ignore parameters? #3

KrisThielemans opened this issue Jul 27, 2020 · 1 comment · Fixed by #5, #8 or #9
Assignees
@casperdcl
Labels
bug Something isn't working

Comments

@KrisThielemans
Copy link
Contributor

I believe these are wrong

brainweb/brainweb/utils.py

Lines 259 to 260 in 202eb40

petNoise=1.0, t1Noise=0.75, t2Noise=0.75,
petSigma=1.0, t1Sigma=1.0, t2Sigma=1.0,

as they overwrite any arguments specified to the function, but should be

petNoise=petNoise, t1Noise=t1Noise, t2Noise=t2Noise, 
 petSigma=petSigma, t1Sigma=t1Sigma, t2Sigma=t2Sigma,
KrisThielemans added a commit to KrisThielemans/brainweb that referenced this issue Jul 27, 2020
@KrisThielemans
fix handling of arguments in get_mmr_fromfile
00543e1 
It ignored values for petNoise etc

Fixes casperdcl#3
@KrisThielemans KrisThielemans mentioned this issue Jul 27, 2020
Merged
@casperdcl
Copy link
Owner

Sorry somehow missed the notification about this! Will fix in <24h

This was referenced Sep 16, 2020
Merged
Merged
@casperdcl casperdcl self-assigned this Sep 16, 2020
@casperdcl casperdcl added the bug Something isn't working label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@KrisThielemans @casperdcl