-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow --output
to be a directory
#546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This should re-use CreateContent::torrent_path
to set the filename, and also needs a test.
I tried that, but it seems to return an absolute path, and |
I added a test, but it's currently failing because |
I believe this check is failing: intermodal/src/subcommand/torrent/create.rs Line 340 in 7812ad2
|
This should be ready for review, unless you'd like me to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently, when the
--output
flag totorrent create
is a directory, imdl errors out with "error: Output path already exists".With this change, it will create a torrent file with the default name, but in the specified directory.
Resolves #525