You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an issue in the EditableInput component, if I try to set s, l, or v in hsl or hsv to 0% or 1% the saturation pointer seems to always jump towards 100% when the input box focuses out.
On removing the focus from the input box it changes from 1% to 100%, this issue only arises when we set 1% or 0% values to the s,l, or v input's.
On further debugging I found out over here at line 80 , the value of s can never be 0 because 0 || (n>0) = n therefore the statement at line 80 could be something like this s: Number( !_.isUndefined(data.s)? data.s : this.props.hsl.s ), over here we can check if data.s isn't undefined and then assign it to the value of s key.
A small demo of the existing issue.
The text was updated successfully, but these errors were encountered:
pizza3
changed the title
EditableInput component can't except 0% & 1% values.
EditableInput component can't accept 0% & 1% values.
May 3, 2020
There is an issue in the
EditableInput
component, if I try to sets
,l
, orv
inhsl
orhsv
to 0% or 1% the saturation pointer seems to always jump towards 100% when the input box focuses out.On removing the focus from the input box it changes from 1% to 100%, this issue only arises when we set 1% or 0% values to the
s
,l
, orv
input's.On further debugging I found out over here at line 80 , the value of
s
can never be 0 because0 || (n>0) = n
therefore the statement at line 80 could be something like thiss: Number( !_.isUndefined(data.s)? data.s : this.props.hsl.s )
, over here we can check ifdata.s
isn't undefined and then assign it to the value ofs
key.A small demo of the existing issue.
The text was updated successfully, but these errors were encountered: