fix: *matcher result should be boolean or number* for KeyGet2

[Shivansh-yadav13]

Fix: #332

• added a case for result type string.
• please suggest changes if required.

[coveralls]

Pull Request Test Coverage Report for Build 1833860796

• -4 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 77.173%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/coreEnforcer.ts	0	4	0.0%

Totals
Change from base Build 1746426510:	-0.2%
Covered Lines:	1323
Relevant Lines:	1644

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1919832746

• 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.07%) to 77.45%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/coreEnforcer.ts	4	5	80.0%

Files with Coverage Reduction	New Missed Lines	%
src/util/util.ts	4	78.08%

Totals
Change from base Build 1746426510:	0.07%
Covered Lines:	1328
Relevant Lines:	1645

---

💛 - Coveralls

[casbin-bot]

@Gabriel-403 @Zxilly @kingiw @nodece please review

[hsluoyz]

@nodece @Zxilly plz review

[hsluoyz]

@Shivansh-yadav13

1. Don't fix two bugs in one PR. Separate into two PRs.
2. AT the issue sender to review

[Shivansh-yadav13]

@tomfriedhof can you please review and suggest changes if required.

[grzegorz-kap]

@Shivansh-yadav13 , when I was debugging it the value of 'result' was undefined.

In our implementation, we have multiple instances of Casbin enforcer.

Steps to reproduce:

1. Create a new Enforce with an empty permission set and call enforce
2. Create a new Enforce with some permissions and call enforce (an error is thrown: matcher result should be boolean or number - result is undefined)
3. Repeat step 2 (no error)

The issue does not occur if step 1 has some permissions

model:

[request_definition]
r = sub, dom, obj, act, v

[policy_definition]
p = sub, dom, obj, act, exp

[role_definition]
g = _, _, _

[policy_effect]
e = some(where (p.eft == allow))

[matchers]
m = g(r.sub, p.sub, r.dom) && r.dom == p.dom && r.obj == p.obj && r.act == p.act && eval(p.exp)

An example of 'exp' from the policy_defintion
(r.v.office=='london'||r.v.office=='warsaw')&&(r.v.floor=='first')

[Shivansh-yadav13]

This is what happening

const enforcer1 = await newEnforcer('examples/test_model.conf');
await enforcer1.enforce('sub', 'dom', '/data1', 'read', { office: 'london', floor: 'first' });

const enforcer2 = await newEnforcer('examples/test_model.conf', 'examples/test_policy.csv');
await enforcer2.enforce('sub', 'dom', '/data1', 'read', { office: 'london', floor: 'first' });

Error --> matcher result should be boolean or number

const enforcer1 = await newEnforcer('examples/test_model.conf', 'examples/test_policy.csv');
await enforcer1.enforce('sub', 'dom', '/data1', 'read', { office: 'london', floor: 'first' });

const enforcer2 = await newEnforcer('examples/test_model.conf');
await enforcer2.enforce('sub', 'dom', '/data1', 'read', { office: 'london', floor: 'first' });

No Error

const enforcer1 = await newEnforcer('examples/test_model.conf');
await enforcer1.enforce('sub', 'dom', '/data1', 'read', { office: 'london', floor: 'first' });

const enforcer2 = await newEnforcer('examples/test_model.conf');
await enforcer2.enforce('sub', 'dom', '/data1', 'read', { office: 'london', floor: 'first' });

No Error

[Shivansh-yadav13]

Steps to reproduce:

1. Create a new Enforce with an empty permission set and call enforce
2. Create a new Enforce with some permissions and call enforce (an error is thrown: matcher result should be boolean or number - result is undefined)
3. Repeat step 2 (no error)

@grzegorz-kap Ig the error you are facing is resolved after #348, can you please confirm.

[nodece]

Could you add unit tests to cover this case?

[Zxilly]

lgtm

[github-actions]

🎉 This PR is included in version 5.13.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀