Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleteUser and improve RBAC test coverage #119

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix deleteUser and improve RBAC test coverage #119

merged 2 commits into from
Feb 20, 2020

Conversation

Sefriol
Copy link
Contributor

@Sefriol Sefriol commented Feb 19, 2020 •
edited
Loading

Tasks:

  • Improve RBAC test coverage
  • fix deleteUser

@Sefriol Sefriol mentioned this pull request Feb 19, 2020
Closed
@hsluoyz
Copy link
Member

hsluoyz commented Feb 20, 2020

@Sefriol please fix CI error.

@nodece
Copy link
Member

nodece commented Feb 20, 2020

@Sefriol lgtm. Can you fix the deleteUser API?

@Sefriol
Copy link
Contributor Author

Sefriol commented Feb 20, 2020

I'll fix that later today!

@Sefriol
test(rbac): improve RBAC test coverage
454165e 
Add more test related to RBAC functionality in enforcer.test.ts and rbacAPI.test.ts
@Sefriol
fix(enforcer.ts): fix deleteUser and improve deleteRole description
1e6af16 
deleteUser now removes related grouping policies and normal policies related to user. Previously
just grouping policies were removed. Now deleteUser is more in line with deleteRole

fix casbin#118
@Sefriol Sefriol changed the title WIP: Fix deleteUser and improve RBAC test coverage Fix deleteUser and improve RBAC test coverage Feb 20, 2020
@Sefriol Sefriol requested review from hsluoyz and nodece February 20, 2020 10:05
hsluoyz
hsluoyz approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@hsluoyz hsluoyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsluoyz
Copy link
Member

hsluoyz commented Feb 20, 2020

Fix: #118

@hsluoyz hsluoyz merged commit c3be710 into casbin:master Feb 20, 2020
@nodece
Copy link
Member

nodece commented Feb 20, 2020

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sefriol Sefriol deleted the fix-delete-user branch February 20, 2020 13:57
@greenhandatsjtu greenhandatsjtu mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsluoyz hsluoyz hsluoyz approved these changes

@nodece nodece Awaiting requested review from nodece

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sefriol @hsluoyz @nodece