Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] CI has error: The engine "node" is incompatible with this module. Expected version ">=20.8.1". Got "18.20.4" #25

Closed
hsluoyz opened this issue Oct 5, 2024 · 4 comments · Fixed by #26 or #27
Closed

[bug] CI has error: The engine "node" is incompatible with this module. Expected version ">=20.8.1". Got "18.20.4" #25

hsluoyz opened this issue Oct 5, 2024 · 4 comments · Fixed by #26 or #27
Assignees
@hsluoyz
Labels
bug Something isn't working released

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Oct 5, 2024

See: https://github.com/casbin/casbin-go-client/actions/runs/11189110788/job/31109024568

image
@casbin-bot casbin-bot added the bug Something isn't working label Oct 5, 2024
@hsluoyz
Copy link
Member Author

hsluoyz commented Oct 5, 2024

@ali-shokoohi can you fix this issue?

ali-shokoohi added a commit to ali-shokoohi/casbin-go-client that referenced this issue Oct 5, 2024
@ali-shokoohi
Fix: casbin#25
3ad88ad 
Added a new step to setup the Node version to "20.8.1".

Changes:
- Added setup Node version step in ".github/workflows/ci.yml" file to use Node version "20.8.1"
@ali-shokoohi ali-shokoohi mentioned this issue Oct 5, 2024
Merged
@hsluoyz hsluoyz closed this as completed in 0747ebe Oct 5, 2024
@hsluoyz hsluoyz reopened this Oct 5, 2024
@hsluoyz
Copy link
Member Author

hsluoyz commented Oct 5, 2024

@ali-shokoohi still error: https://github.com/casbin/casbin-go-client/actions/runs/11191893534/job/31115381958

Can you take a look? You can fork this repo and test the semantic-release on your side to see if your fix actually works before making PR

ali-shokoohi added a commit to ali-shokoohi/casbin-go-client that referenced this issue Oct 5, 2024
@ali-shokoohi
Fix: casbin#25
909b5f3 
Removed updating PATH because it make us to use old version of Node and getting error
@ali-shokoohi ali-shokoohi mentioned this issue Oct 5, 2024
Merged
@ali-shokoohi
Copy link
Contributor

You're right @hsluoyz .
Now I merged my changes in my fork and tested it.
https://github.com/ali-shokoohi/casbin-go-client/tree/develop

hsluoyz added a commit that referenced this issue Oct 5, 2024
@ali-shokoohi @hsluoyz
feat: fix Node engine version after installing new version of Node (#27)
2f9c0f9 
* Fix: #25

Added a new step to setup the Node version to "20.8.1".

Changes:
- Added setup Node version step in ".github/workflows/ci.yml" file to use Node version "20.8.1"

* Specified Ubuntu vesrion to prevent same version conflicts in the future

Changes:
- Specified Ubuntu version in "runs-on" steps

* Update ci.yml

* Replaced docker action with "docker/setup-buildx-action@v3" action instead of "docker-practice/actions-setup-docker@master" because that wasn't compatible with newest Ubuntu version: 24.04

* Fix: #25

Removed updating PATH because it make us to use old version of Node and getting error

---------

Co-authored-by: Yang Luo <hsluoyz@qq.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
3 participants
@hsluoyz @ali-shokoohi @casbin-bot