Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unix build to fast fail when compile-time errors and fix file boostraping for VS. #70

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

divy9881
Copy link
Member

@divy9881 divy9881 commented Jan 7, 2021

The PR: #67's CI should fail as it consists of compile-time errors for Unix build. After this fix travis CI will return valid exit error codes to fail the CI.

…ning process.

Signed-off-by: divy9881 <divy9881@gmail.com>
@divy9881 divy9881 requested a review from hsluoyz January 7, 2021 10:28
@divy9881 divy9881 force-pushed the fix_unix_build branch 2 times, most recently from 3d601b3 to a73a9ef Compare January 7, 2021 11:52
Signed-off-by: divy9881 <divy9881@gmail.com>
@hsluoyz hsluoyz merged commit 978abe1 into casbin:master Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 1.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hsluoyz
Copy link
Member

hsluoyz commented Jan 7, 2021

But I didn't see the CI error in:#67 why?

@divy9881
Copy link
Member Author

divy9881 commented Jan 7, 2021

But I didn't see the CI error in:#67 why?

CI has failed now, after adding new commits to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants