feat: Add RBAC API with Domains tests.

Signed-off-by: DivyPatel9881 <divy9881@gmail.com>
casbin · Jul 14, 2020 · 5070296 · 5070296
1 parent 21b31ad
commit 5070296
Show file tree

Hide file tree

Showing 9 changed files with 189 additions and 19 deletions.
diff --git a/test/test.vcxproj b/test/test.vcxproj
@@ -172,6 +172,7 @@
     <ClCompile Include="test_model.cpp" />
     <ClCompile Include="test_model_enforcer.cpp" />
     <ClCompile Include="test_rbac_api.cpp" />
+    <ClCompile Include="test_rbac_api_with_domains.cpp" />
     <ClCompile Include="test_role_manager.cpp" />
     <ClCompile Include="test_util.cpp" />
   </ItemGroup>

diff --git a/test/test.vcxproj.filters b/test/test.vcxproj.filters
@@ -45,6 +45,9 @@
     <ClCompile Include="test_rbac_api.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
+    <ClCompile Include="test_rbac_api_with_domains.cpp">
+      <Filter>Source Files</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="pch.h">

diff --git a/test/test_config.cpp b/test/test_config.cpp
@@ -2,9 +2,6 @@
 
 #include "pch.h"
 
-#include <direct.h>
-#include <algorithm>
-
 #include <config.h>
 #include <util.h>
 

diff --git a/test/test_enforcer.cpp b/test/test_enforcer.cpp
@@ -2,9 +2,6 @@
 
 #include "pch.h"
 
-#include <direct.h>
-#include <algorithm>
-
 #include <enforcer.h>
 #include <persist.h>
 #include <rbac.h>

diff --git a/test/test_management_api.cpp b/test/test_management_api.cpp
@@ -2,10 +2,6 @@
 
 #include "pch.h"
 
-#include <direct.h>
-#include <algorithm>
-#include <fstream>
-
 #include <enforcer.h>
 #include <persist.h>
 #include <config.h>

diff --git a/test/test_model.cpp b/test/test_model.cpp
@@ -2,8 +2,6 @@
 
 #include "pch.h"
 
-#include <direct.h>
-#include <algorithm>
 #include <fstream>
 
 #include <util.h>

diff --git a/test/test_model_enforcer.cpp b/test/test_model_enforcer.cpp
@@ -2,9 +2,6 @@
 
 #include "pch.h"
 
-#include <direct.h>
-#include <algorithm>
-
 #include <enforcer.h>
 #include <persist.h>
 #include <rbac.h>

diff --git a/test/test_rbac_api.cpp b/test/test_rbac_api.cpp
@@ -2,10 +2,6 @@
 
 #include "pch.h"
 
-#include <direct.h>
-#include <algorithm>
-#include <fstream>
-
 #include <enforcer.h>
 #include <rbac.h>
 #include <util.h>

diff --git a/test/test_rbac_api_with_domains.cpp b/test/test_rbac_api_with_domains.cpp
@@ -0,0 +1,185 @@
+#pragma once
+
+#include "pch.h"
+
+#include <enforcer.h>
+#include <exception.h>
+#include <rbac.h>
+#include <util.h>
+
+using namespace std;
+
+namespace test_rbac_api_with_domains
+{
+    TEST_CLASS(TestRBACAPIWithDomains)
+    {
+        public:
+
+            TEST_METHOD(TestGetImplicitRolesForDomainUser) {
+                Enforcer* e = Enforcer::NewEnforcer("../../examples/rbac_with_domains_model.conf", "../../examples/rbac_with_hierarchy_with_domains_policy.csv");
+
+                // This is only able to retrieve the first level of roles.
+                Assert::IsTrue(ArrayEquals({ "role:global_admin" }, e->GetRolesForUserInDomain("alice", { "domain1" })));
+
+                // Retrieve all inherit roles. It supports domains as well.
+                Assert::IsTrue(ArrayEquals(vector<string>{"role:global_admin", "role:reader", "role:writer"}, e->GetImplicitRolesForUser("alice", {"domain1"})));
+            }
+
+            // TestUserAPIWithDomains: Add by Gordon
+            TEST_METHOD(TestUserAPIWithDomains) {
+                Enforcer* e = Enforcer::NewEnforcer("../../examples/rbac_with_domains_model.conf", "../../examples/rbac_with_domains_policy.csv");
+
+                Assert::IsTrue(ArrayEquals({ "alice" }, e->GetUsersForRole("admin", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ "alice" }, e->GetUsersForRoleInDomain("admin", { "domain1" })));
+
+                try {
+                    e->GetUsersForRole("non_exist", { "domain1" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+                try {
+                    e->GetUsersForRoleInDomain("non_exist", { "domain1" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+
+                Assert::IsTrue(ArrayEquals({ "bob" }, e->GetUsersForRole("admin", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ "bob" }, e->GetUsersForRoleInDomain("admin", { "domain2" })));
+
+                try {
+                    e->GetUsersForRole("non_exist", { "domain2" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+                try {
+                    e->GetUsersForRoleInDomain("non_exist", { "domain2" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+
+                e->DeleteRoleForUserInDomain("alice", "admin", "domain1");
+                e->AddRoleForUserInDomain("bob", "admin", "domain1");
+
+                Assert::IsTrue(ArrayEquals({ "bob" }, e->GetUsersForRole("admin", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ "bob" }, e->GetUsersForRoleInDomain("admin", { "domain1" })));
+
+                try {
+                    e->GetUsersForRole("non_exist", { "domain1" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+                try {
+                    e->GetUsersForRoleInDomain("non_exist", { "domain1" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+
+                Assert::IsTrue(ArrayEquals({ "bob" }, e->GetUsersForRole("admin", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ "bob" }, e->GetUsersForRoleInDomain("admin", { "domain2" })));
+
+                try {
+                    e->GetUsersForRole("non_exist", { "domain2" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+                try {
+                    e->GetUsersForRoleInDomain("non_exist", { "domain2" });
+                }
+                catch (CasbinRBACException e) {
+                    Assert::IsTrue(true);
+                }
+            }
+
+            TEST_METHOD(TestRoleAPIWithDomains) {
+                Enforcer* e = Enforcer::NewEnforcer("../../examples/rbac_with_domains_model.conf", "../../examples/rbac_with_domains_policy.csv");
+
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUser("alice", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUserInDomain("alice", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("bob", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("bob", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("admin", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("admin", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("non_exist", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("non_exist", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("alice", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("alice", { "domain2" })));
+
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUser("bob", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUserInDomain("bob", { "domain2" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("admin", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("admin", { "domain2" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("non_exist", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("non_exist", { "domain2" })));
+
+                e->DeleteRoleForUserInDomain("alice", "admin", "domain1");
+                e->AddRoleForUserInDomain("bob", "admin", "domain1");
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("alice", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("alice", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUser("bob", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUserInDomain("bob", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("admin", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("admin", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("non_exist", { "domain1" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("non_exist", { "domain1" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("alice", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("alice", { "domain2" })));
+
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUser("bob", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ "admin" }, e->GetRolesForUserInDomain("bob", { "domain2" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("admin", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("admin", { "domain2" })));
+
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUser("non_exist", { "domain2" })));
+                Assert::IsTrue(ArrayEquals({ }, e->GetRolesForUserInDomain("non_exist", { "domain2" })));
+            }
+
+            void TestGetPermissionsInDomain(Enforcer* e, string name, string domain, vector<vector<string>> res) {
+                vector<vector<string>> my_res = e->GetPermissionsForUserInDomain(name, { domain });
+
+                int count = 0;
+                for (int i = 0; i < my_res.size(); i++) {
+                    for (int j = 0; j < res.size(); j++) {
+                        if (ArrayEquals(res[j], my_res[i])) {
+                            count += 1;
+                            break;
+                        }
+                    }
+                }
+
+                Assert::AreEqual(int(res.size()), count);
+            }
+
+            TEST_METHOD(TestPermissionAPIInDomain) {
+                Enforcer* e = Enforcer::NewEnforcer("../../examples/rbac_with_domains_model.conf", "../../examples/rbac_with_domains_policy.csv");
+
+                TestGetPermissionsInDomain(e, "alice", "domain1", {});
+                TestGetPermissionsInDomain(e, "bob", "domain1", {});
+                TestGetPermissionsInDomain(e, "admin", "domain1", { {"admin", "domain1", "data1", "read"}, {"admin", "domain1", "data1", "write"} });
+                TestGetPermissionsInDomain(e, "non_exist", "domain1", {});
+
+                TestGetPermissionsInDomain(e, "alice", "domain2", {});
+                TestGetPermissionsInDomain(e, "bob", "domain2", {});
+                TestGetPermissionsInDomain(e, "admin", "domain2", { {"admin", "domain2", "data2", "read"}, {"admin", "domain2", "data2", "write"} });
+                TestGetPermissionsInDomain(e, "non_exist", "domain2", {});
+            }
+    };
+}