Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upparat: limit exponential backoff max time #10

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

livioso
Copy link
Contributor

@livioso livioso commented Mar 2, 2020

This mitigates #9.

Till now, the backoff would just keep increasing. Not entirely sure what's an appropriate max_value to choose since we have vastly different use cases (could fail due to auth issues, could fail because the connection is flaky ...). Nonetheless, I would argue it makes sense to set it.

Any concerns with 64s?

closes #9.

@livioso livioso self-assigned this Mar 2, 2020
Copy link
Contributor

@aeby aeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64s probably is on the lower end, but with not that many devices I guess it is ok.

Copy link
Contributor

@philippbachmann08 philippbachmann08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
64s might be low for certain scenarios like Soest where bandwith seems to be limited. But for now it's not the plan to update too many devices at once

@livioso livioso merged commit 62d7e35 into master Mar 3, 2020
@livioso livioso deleted the backoff-expo-max-value branch March 3, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[upparat] Less aggressive backoff behaviour
3 participants