proto3 switch-over RFC #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2017 08:46
wohe
approved these changes
Nov 8, 2017
|
Should the plan for |
|
I think that's a great idea but should be documented in a different RFC. |
SirVer
approved these changes
Nov 10, 2017
gaschler
approved these changes
Nov 10, 2017
text/0000-proto3-transition.md
Outdated
| ## Discussion Points | ||
| [discussion]: #discussion | ||
|
|
||
| [FirstPR]: https://github.com/googlecartographer/cartographer/pull/635 |
There was a problem hiding this comment.
I think it should be cartographer-project/cartographer#644 instead
ojura
reviewed
Nov 10, 2017
| - Refactor any code that uses proto2 features ('has...') and convert (at the very least) those messages that we intend to send over the wire to proto3 style. | ||
|
|
||
| This [PR][FirstPR] summarizes the plan for step 1 for the Cartographer repo: | ||
| - We add a script 'install_proto3.sh' which clones proto3 from HEAD, compiles and installs it to '/usr/local'. |
There was a problem hiding this comment.
From HEAD, or from a certain version, like Ceres?
There was a problem hiding this comment.
Good call. I think Holger already has a follow-up PR where he does exactly that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered