Add a Bazel build for cartographer #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not include cartographer_grpc, nor any of the binaries (*_main.cc). It has been tested with Bazel 0.9.0 on Ubuntu 14.04 with the latest (at time of writing) dazel/dazel container, by running: ``` bazel build //... bazel test //... ```
SirVer
reviewed
Jan 22, 2018
cschuet
approved these changes
Jan 22, 2018
| @@ -0,0 +1,17 @@ | |||
| # Copyright 2018 The Cartographer Authors | |||
There was a problem hiding this comment.
Is it important that this is in tools? We have a cmake subdirectory. Should we rather have this file in a bazel subdirectory?
There was a problem hiding this comment.
As discussed this one needs to stay but others have gone into the subfolder.
There was a problem hiding this comment.
|
@wally-the-cartographer merge |
|
Merge requested by authorized user cschuet. Merge queue now has a length of 1. |
MichaelGrupp
pushed a commit
to magazino/cartographer
that referenced
this pull request
Mar 6, 2018
This does not include cartographer_grpc, nor any of the binaries (*_main.cc). It has been tested with Bazel 0.9.0 on Ubuntu 14.04 with the latest (at time of writing) dazel/dazel container, by running: ``` bazel build //... bazel test //... ``` While this is a large CL, the files under third_party are not new - they have been through internal review, and this is their open-source release. The other files come to 212 lines of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not include cartographer_grpc, nor any of the binaries
(*_main.cc). It has been tested with Bazel 0.9.0 on Ubuntu 14.04 with
the latest (at time of writing) dazel/dazel container, by running:
While this is a large CL, the files under third_party are not new - they have been through internal review, and this is their open-source release. The other files come to 212 lines of code.