feat(formatter): always break property hooks into multiple lines #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the formatter to always break property hooks (getters and setters) into multiple lines, regardless of the `print_width` setting. Previously, property hooks were only broken into multiple lines if they didn't fit within the `print_width`. This change ensures consistent formatting and improves readability, especially for users with large `print_width` values.
The only exception is when a property hook list is empty (`{}`), in which case it remains on a single line.
This addresses an issue where property hooks could unexpectedly become single-line when `print_width` was very large, leading to poor readability.
Signed-off-by: azjezz <azjezz@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What Does This PR Do?
This PR modifies the formatter to always break property hooks (getters and setters) into multiple lines, regardless of the
print_widthsetting.🔍 Context & Motivation
Previously, property hooks were only broken into multiple lines if they didn't fit within the
print_width. This could lead to unexpected single-line property hooks when users had a very largeprint_widthvalue, compromising readability. This change ensures consistent formatting and improves readability for all users.🛠️ Summary of Changes
📂 Affected Areas
🔗 Related Issues or PRs
Closes #124
📝 Notes for Reviewers