Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(formatter): remove keyword_case option #108

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

azjezz
Copy link
Member

@azjezz azjezz commented Mar 4, 2025

📌 What Does This PR Do?

This PR removes the keyword_case option from the formatter configuration.

🔍 Context & Motivation

The keyword_case option allowed users to control the casing of keywords (e.g., class, function, if) in the formatted output. However, this option is rarely used, and changing the casing of keywords can lead to code that deviates from standard conventions.

This PR removes this option to simplify the formatter configuration and ensure that keywords are always formatted in lowercase, promoting consistency and adherence to common practices.

🛠️ Summary of Changes

  • Refactor: Removed the keyword_case option from the formatter configuration.
  • Refactor: Keywords are now always formatted in lowercase.
  • Test: Updated tests to reflect the removal of the option and the consistent lowercase formatting of keywords.

📂 Affected Areas

  • Linter
  • Formatter
  • CLI
  • Composer Plugin
  • Dependencies
  • Documentation
  • Other (please specify):

🔗 Related Issues or PRs

📝 Notes for Reviewers

Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing would be a serious error. Type: BC Break A change that introduces backward compatibility breaks in the public API. Subject: Formatter An issue or PR related to the formatter. labels Mar 4, 2025
@azjezz azjezz self-assigned this Mar 4, 2025
@azjezz azjezz merged commit 3987266 into main Mar 4, 2025
4 checks passed
@azjezz azjezz deleted the chore/remove-keyword-casing-option branch March 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical This should be dealt with ASAP. Not fixing would be a serious error. Subject: Formatter An issue or PR related to the formatter. Type: BC Break A change that introduces backward compatibility breaks in the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant