Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bum Rust to 1.78.0 #402

Merged
merged 1 commit into from
May 8, 2024
Merged

Bum Rust to 1.78.0 #402

merged 1 commit into from
May 8, 2024

Conversation

fmoura
Copy link
Contributor

@fmoura fmoura commented May 7, 2024 •
edited
Loading

Closes #400

@fmoura fmoura self-assigned this May 7, 2024
@fmoura fmoura changed the base branch from main to next/2.0 May 7, 2024 17:23
@fmoura fmoura force-pushed the feature/bump-rust-1780 branch from 72a27d2 to c63d661 Compare May 7, 2024 17:38
@fmoura fmoura marked this pull request as ready for review May 7, 2024 18:20
marcelstanley
marcelstanley reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@marcelstanley marcelstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if you could:

  1. Split the bump itself and the clippy changes into two separate commits
  2. Provide more details in the "clippy" commit regarding what issues were circumvented/bypassed the changes

@fmoura
Copy link
Contributor Author

fmoura commented May 7, 2024

Is it valid to have a "broken" Commit ? because just bumping the Rust version will leave it broken. And I can add the details at the single commit

@fmoura fmoura force-pushed the feature/bump-rust-1780 branch from c63d661 to 8682b9b Compare May 7, 2024 19:17
@fmoura fmoura requested a review from marcelstanley May 7, 2024 19:18
@fmoura fmoura linked an issue May 7, 2024 that may be closed by this pull request
Bump Rust version to 1.78.0 #400
Closed
4 tasks
@marcelstanley
Copy link
Contributor

marcelstanley commented May 7, 2024 •
edited
Loading

Is it valid to have a "broken" Commit ? because just bumping the Rust version will leave it broken. And I can add the details at the single commit

As long as the commit with the fix is merged alongside the broken commit, I don't see a problem. But I'm fine with a single commit as well, if you prefer.

@fmoura fmoura marked this pull request as draft May 7, 2024 19:38
@fmoura fmoura force-pushed the feature/bump-rust-1780 branch 2 times, most recently from 3e9bfe3 to 833f16f Compare May 8, 2024 00:57
@fmoura
chore: Bump Rust to 1.78.0
91b254c 
Added general '-A clippy::mixed_attributes_style' to CI clippy execution to avoid linter warning on the automatically generated file 'iconsensus.rs'
@fmoura fmoura force-pushed the feature/bump-rust-1780 branch from 833f16f to 91b254c Compare May 8, 2024 01:09
@fmoura fmoura marked this pull request as ready for review May 8, 2024 01:13
@fmoura
Copy link
Contributor Author

fmoura commented May 8, 2024

Dead Code removed

@fmoura fmoura merged commit b88c547 into next/2.0 May 8, 2024
5 checks passed
@fmoura fmoura deleted the feature/bump-rust-1780 branch May 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstanley marcelstanley marcelstanley approved these changes

@gligneul gligneul gligneul approved these changes

@renan061 renan061 Awaiting requested review from renan061

Assignees

@fmoura fmoura

Labels
None yet
Projects
Node Unit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Rust version to 1.78.0
3 participants
@fmoura @marcelstanley @gligneul