Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate notice command #270

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add validate notice command #270

merged 2 commits into from
Jan 23, 2024

Conversation

GMKrieger
Copy link
Contributor

@GMKrieger GMKrieger added the #feat:rollups-cli Feature: cartesi-rollups-cli label Jan 22, 2024
@GMKrieger GMKrieger self-assigned this Jan 22, 2024
@GMKrieger GMKrieger linked an issue Jan 22, 2024 that may be closed by this pull request
Add command to validate notice #192
Closed
2 tasks
@GMKrieger GMKrieger force-pushed the feature/cli-validate-notice branch from 8fe4dff to b4d86fc Compare January 22, 2024 14:06
gligneul
gligneul suggested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor comments.

gligneul
gligneul reviewed Jan 22, 2024
View reviewed changes
@GMKrieger GMKrieger force-pushed the feature/cli-validate-notice branch 2 times, most recently from 0ed9846 to 5f09036 Compare January 22, 2024 18:46
gligneul
gligneul suggested changes Jan 23, 2024
View reviewed changes
@GMKrieger GMKrieger force-pushed the feature/cli-validate-notice branch from 5f09036 to 4fac5e9 Compare January 23, 2024 16:24
@gligneul gligneul force-pushed the feature/cli-validate-notice branch from 4fac5e9 to 3f20c19 Compare January 23, 2024 16:43
@gligneul gligneul force-pushed the feature/cli-validate-notice branch from 3f20c19 to 4c39a5b Compare January 23, 2024 16:51
@gligneul gligneul merged commit 683e43b into main Jan 23, 2024
4 checks passed
@gligneul gligneul deleted the feature/cli-validate-notice branch January 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

Assignees

@GMKrieger GMKrieger

Labels
#feat:rollups-cli Feature: cartesi-rollups-cli
Projects
Node Unit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command to validate notice
2 participants
@GMKrieger @gligneul