Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cmd run deps #224

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Feature/cmd run deps #224

merged 1 commit into from
Jan 24, 2024

Conversation

fmoura
Copy link
Contributor

@fmoura fmoura commented Dec 29, 2023 •
edited
Loading

closes #217

@fmoura fmoura self-assigned this Dec 29, 2023
@fmoura fmoura force-pushed the feature/cmd-run-deps branch from 2cc9fd1 to 6b50289 Compare December 29, 2023 18:40
@fmoura fmoura changed the base branch from main to feature/cmd-machine-snapshot December 29, 2023 18:41
@fmoura fmoura added the no changelog PRs that don't require changes in changelog label Dec 29, 2023
@fmoura fmoura force-pushed the feature/cmd-machine-snapshot branch from 234c605 to 7ed6b81 Compare January 3, 2024 15:57
@fmoura fmoura force-pushed the feature/cmd-run-deps branch from 6b50289 to dd77983 Compare January 3, 2024 16:00
@fmoura fmoura force-pushed the feature/cmd-machine-snapshot branch from 7ed6b81 to d0b91bd Compare January 3, 2024 16:46
Base automatically changed from feature/cmd-machine-snapshot to main January 3, 2024 21:46
@fmoura fmoura force-pushed the feature/cmd-run-deps branch 3 times, most recently from a1dd2a3 to 1307c95 Compare January 5, 2024 18:23
@gligneul gligneul self-requested a review January 5, 2024 18:31
gligneul
gligneul suggested changes Jan 8, 2024
View reviewed changes
@gligneul gligneul linked an issue Jan 10, 2024 that may be closed by this pull request
Add command to run dependencies on docker #217
Closed
@fmoura fmoura force-pushed the feature/cmd-run-deps branch 3 times, most recently from 86e781a to 4ac3fef Compare January 11, 2024 17:11
@fmoura fmoura requested a review from gligneul January 11, 2024 17:31
@fmoura fmoura force-pushed the feature/cmd-run-deps branch 4 times, most recently from de04a38 to a3e74da Compare January 17, 2024 15:23
@fmoura fmoura added this to the 1.3.0 milestone Jan 17, 2024
gligneul
gligneul suggested changes Jan 18, 2024
View reviewed changes
@fmoura fmoura force-pushed the feature/cmd-run-deps branch 2 times, most recently from 03d1a98 to f74e9e5 Compare January 23, 2024 02:07
gligneul
gligneul suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor details.

endersonmaia
endersonmaia reviewed Jan 23, 2024
View reviewed changes
@fmoura fmoura force-pushed the feature/cmd-run-deps branch from f74e9e5 to 5886a43 Compare January 23, 2024 19:06
@fmoura fmoura force-pushed the feature/cmd-run-deps branch 3 times, most recently from 4d0ced1 to e2ca3dc Compare January 23, 2024 21:07
@gligneul gligneul force-pushed the feature/cmd-run-deps branch from e2ca3dc to 302b06a Compare January 24, 2024 13:31
@gligneul gligneul force-pushed the feature/cmd-run-deps branch from 302b06a to bd31565 Compare January 24, 2024 14:29
@gligneul gligneul merged commit 0623cb8 into main Jan 24, 2024
5 checks passed
@gligneul gligneul deleted the feature/cmd-run-deps branch January 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@endersonmaia endersonmaia Awaiting requested review from endersonmaia

Assignees

@fmoura fmoura

Labels
no changelog PRs that don't require changes in changelog
Projects
Node Unit
Status: ✅ Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Add command to run dependencies on docker
3 participants
@fmoura @endersonmaia @gligneul