-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagonal ref. line to plot_predictions() function #476
base: main
Are you sure you want to change the base?
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-476 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-06-04 18:42:59 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the addition! This does change all the plots in this episode right? Can you upload the new images?
Correct, @svenvanderburg, it updates all the plots in the episode (that show true vs predicted points) since I updated the plot_predictions() function directly. See attached an example plot from the episode. |
Yes, I think it is a neat addition! If you have the time can you add the updated plots? (I think it is confusing if we only add the code and not the corresponding plots). If you don't have time we can pick it up during our next sprint. By the way @qualiaMachine did you see we have an upcoming sprint 22 & 23rd of July? https://github.com/carpentries-incubator/deep-learning-intro?tab=readme-ov-file#lesson-development-sprints . Maybe you would like to join (in any form of capacity you have)? |
Happy to add the plots this week :). I wish I could make the sprints, but 10 CEST will be 3am in my time zone. Might have to skip that one haha. |
Check. If you are interested we could meet around 16:00 CEST, which would be 9:00 in your time zone then? |
It's very useful to have a diagonal reference line when viewing scatterplots that plot true vs predicted data. Deviations above/below the diagonal tell you where the model is making more mistakes.