Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: cannot reproduce travis ci error #77

Closed
wants to merge 15 commits into from
Closed

WIP: cannot reproduce travis ci error #77

wants to merge 15 commits into from

Conversation

carocad
Copy link
Owner

@carocad carocad commented Aug 16, 2020

No description provided.

@sogaiu
Copy link

sogaiu commented Aug 17, 2020

In: 05c99f4

I noticed the changes going from:

metadata: ((metadata_entry | deprecated_metadata_entry) ignore*)+
...
metadata_entry: '^' ( map | symbol | string | keyword | macro_keyword );
...
deprecated_metadata_entry: '#^' ( map | symbol | string | keyword | macro_keyword );

to:

metadata: (metadata_entry | deprecated_metadata_entry)+
...
metadata_entry: '^' ignore* ( map | symbol | string | keyword | macro_keyword ) ignore*;
...
deprecated_metadata_entry: '#^' ignore* ( map | symbol | string | keyword | macro_keyword ) ignore*;

I understand the ignore* instances immediately after ^ and ^# -- thanks for those :)

I would like to understand the reasoning for moving the ignore* from the end of metadata to the end of metadata_entry and deprecated_metadata_entry. If you don't mind, please share your thoughts on this matter.

Also on a tangential note, I noticed the bump in version number. If I find any other things would you prefer to hear about them sooner or after another release?

@carocad
Copy link
Owner Author

carocad commented Aug 17, 2020

hey @sogaiu this is a draft PR of an unrelated issue. Right now I cannot reproduce the error from travis ci so I started this draft PR just to try to pinpoint that. I will explain your other questions in #75

@carocad carocad changed the base branch from master to reader/ignore August 17, 2020 06:49
@carocad carocad changed the title Kartoffel WIP: cannot reproduce travis ci error Aug 17, 2020
Base automatically changed from reader/ignore to master August 24, 2020 19:03
@carocad carocad closed this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants