Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash warning after embed-resource version bump; enable clippy in ci #321

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

alsuren
Copy link
Collaborator

@alsuren alsuren commented Nov 11, 2024

I just pulled main and got:

warning: unused `embed_resource::CompilationResult` that must be used
 --> cargo-quickinstall/build.rs:6:5
  |
6 |     embed_resource::compile("manifest.rc", embed_resource::NONE);
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-must-use` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_must_use)]`
help: use `let _ = ...` to ignore the resulting value
  |
6 |     let _ = embed_resource::compile("manifest.rc", embed_resource::NONE);
  |     +++++++

warning: `cargo-quickinstall` (build script) generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.96s

This seems like it was caused by #319 and not caught by our CI.

I also ran clippy in the stats-server project and found another warning.

@alsuren alsuren requested a review from NobodyXu November 11, 2024 14:29
.github/workflows/test.yml Outdated Show resolved Hide resolved
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
Signed-off-by: David Laban <alsuren@gmail.com>
@alsuren alsuren merged commit 456b1a2 into main Nov 12, 2024
33 checks passed
@alsuren alsuren deleted the squash-warnings branch November 12, 2024 08:23
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants