Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to guess_host_triple if rustc -vV failed #136

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Fallback to guess_host_triple if rustc -vV failed #136

merged 2 commits into from
Jan 18, 2023

Conversation

NobodyXu
Copy link
Member

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from alsuren January 18, 2023 05:36
@NobodyXu NobodyXu merged commit f826576 into main Jan 18, 2023
@NobodyXu NobodyXu deleted the fallback branch January 18, 2023 05:40
@alsuren
Copy link
Collaborator

alsuren commented Jan 29, 2023

What are the circumstances that actually cause rustc -vV to fail? This feels like an edge case that isn't worth 30 seconds of build time - #149 (comment)

@NobodyXu
Copy link
Member Author

What are the circumstances that actually cause rustc -vV to fail? This feels like an edge case that isn't worth 30 seconds of build time - #149 (comment)

Well, it fails when rustc isn't present.

If we can assume rustc always prrsent, then we can revert this.

@alsuren
Copy link
Collaborator

alsuren commented Jan 29, 2023

I don't think we provide any instructions for installing cargo-quickinstall without using cargo. We also install things into a place that would only be in your $PATH if you are using rust, and if something isn't installed then we fallback to using cargo install.

It seems reasonable to assume that cargo and rustc are installed. It might be worth going around and adding nice error messages for when our runtime dependencies aren't available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants