Enable --icf=safe for release build

[NobodyXu]

Fixed #663

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

[NobodyXu]

Same as before: Succeeded on windows but failed on all other targets.

[passcod]

We could enable it on just windows

[NobodyXu]

We could enable it on just windows

Yes, I was thinking more of enable it everywhere, but enabling it on win is certainly better than not enable it at all.

BTW, perhaps we can change the system linker to lld to fix this issue?

[passcod]

We can try but I'm not sure how easy to do so it is in CI and without messing people's setups locally

[NobodyXu]

We can try but I'm not sure how easy to do so it is in CI and without messing people's setups locally

Turns out we can archive that via rustflags https://stackoverflow.com/questions/57812916/how-do-i-change-the-default-rustc-cargo-linker

[NobodyXu]

Actually lld is the fastest linker (except for mold on non-lto builds), so switching to lld should also improve build-time.

[NobodyXu]

I would try this in #722

[NobodyXu]

I would try this in #722

Eh actually let's do this in another PR after releasing 0.19.3