Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CI with just and make it possible to run locally #660

Merged
merged 75 commits into from
Jan 8, 2023
Merged

Simplify CI with just and make it possible to run locally #660

merged 75 commits into from
Jan 8, 2023

Conversation

passcod
Copy link
Member

@passcod passcod commented Jan 7, 2023

No description provided.

NobodyXu
NobodyXu requested changes Jan 7, 2023
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Jan 7, 2023
View reviewed changes
justfile Outdated Show resolved Hide resolved
@passcod passcod marked this pull request as ready for review January 8, 2023 02:15
@passcod passcod requested a review from NobodyXu January 8, 2023 02:15
NobodyXu
NobodyXu requested changes Jan 8, 2023
View reviewed changes
.github/workflows/release-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Jan 8, 2023
View reviewed changes
Copy link
Member

@NobodyXu NobodyXu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many changes that I can only skim through them, but overall I think this PR is in good shape.

justfile Show resolved Hide resolved
@NobodyXu
Copy link
Member

NobodyXu commented Jan 8, 2023

5m for release build, not too bad.

@NobodyXu
Copy link
Member

NobodyXu commented Jan 8, 2023 •
edited
Loading

It seems that the old CI jobs (test, unit tests) is still listed in the PR and might block it from being merged?

@passcod
Copy link
Member Author

passcod commented Jan 8, 2023

might block it from being merged

yeah I'll change that just before merging, once this is approved :)

@passcod
Copy link
Member Author

passcod commented Jan 8, 2023

All ready now :)

@passcod passcod enabled auto-merge (squash) January 8, 2023 04:46
NobodyXu
NobodyXu requested changes Jan 8, 2023
View reviewed changes
.github/workflows/release-build.yml Outdated Show resolved Hide resolved
@passcod passcod merged commit aea9df6 into main Jan 8, 2023
@passcod passcod deleted the justfile branch January 8, 2023 05:27
This was referenced Jan 9, 2023
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@passcod @NobodyXu