This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAR-4260 extract header #187
CAR-4260 extract header #187
Changes from 7 commits
d36f5ee
62f0d93
19dcc6d
7338ef9
457aba1
f97e2c4
4be4fd6
358da1b
53bc1c6
07a67b7
14164a2
9db36a1
089904e
072e5f9
0d3b9f0
6707772
de426bd
fb9468d
2ca9426
c38ce92
d064016
5649f2b
9dd2748
4ccff85
22b39ef
fe37d3f
36a9b07
2ce8e58
a1fe15d
0bbee04
22d9edd
123694e
3b83f12
fd2920d
dab800f
b64fe2d
1437f73
e1542ed
d759a80
29f9436
adc305f
775dbe3
e145621
bc3dbb0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fragments should not be required here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments like these are a great pointer to extracting the code into functions where you can slap a name on it
renderDesktopLinks()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice input, makes it a look easier to read with the named functions :)